Skip to content

Commit

Permalink
fixed a few bugs
Browse files Browse the repository at this point in the history
added more log in case of 404
bumped version to 1.1
  • Loading branch information
simplesteph committed May 1, 2017
1 parent 9de09cc commit f51ecea
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.simplesteph.kafka</groupId>
<artifactId>kafka-connect-github-source</artifactId>
<version>1.0</version>
<version>1.1</version>
<packaging>jar</packaging>

<name>kafka-connect-github-source</name>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ protected JSONArray getNextIssues(Integer page, Instant since) throws Interrupte
Thread.sleep(1000 * sleepTime);
return getNextIssues(page, since);
default:
log.error(constructUrl(page, since));
log.error(String.valueOf(jsonResponse.getStatus()));
log.error(jsonResponse.getBody().toString());
log.error(jsonResponse.getHeaders().toString());
Expand Down
9 changes: 4 additions & 5 deletions src/main/java/com/simplesteph/kafka/GitHubSchemas.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public class GitHubSchemas {
public static String NEXT_PAGE_FIELD = "next_page";

// Issue fields
public static String FULL_REPO_FIELD = "owner/repository";
public static String OWNER_FIELD = "owner";
public static String REPOSITORY_FIELD = "repository";
public static String CREATED_AT_FIELD = "created_at";
Expand All @@ -32,10 +31,10 @@ public class GitHubSchemas {
public static String PR_HTML_URL_FIELD = "html_url";

// Schema names
public static String SCHEMA_KEY = "GitHub Issue Key";
public static String SCHEMA_VALUE_ISSUE = "Issue";
public static String SCHEMA_VALUE_USER = "User";
public static String SCHEMA_VALUE_PR = "PR";
public static String SCHEMA_KEY = "issue_key";
public static String SCHEMA_VALUE_ISSUE = "issue";
public static String SCHEMA_VALUE_USER = "user";
public static String SCHEMA_VALUE_PR = "pr";

// Key Schema
public static Schema KEY_SCHEMA = SchemaBuilder.struct().name(SCHEMA_KEY)
Expand Down

0 comments on commit f51ecea

Please sign in to comment.