Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant default config line and unused imports #219

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Remove redundant default config line and unused imports #219

merged 2 commits into from
Oct 17, 2023

Conversation

nohjunh
Copy link
Contributor

@nohjunh nohjunh commented Oct 17, 2023 •
edited
Loading

🎯 Goal

Removing redundant codes from buildSrc's Configuration and build-logic Setup

🛠 Implementation details

  1. Remove defaultConfig.targetSdk line defined in Android ApplicationConventionPlugin and AndroidLibrary ConventionPlugin
  2. Remove unused imports from AndroidLibraryConventionPlugin

✍️ Explain examples

Nothing

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

@nohjunh nohjunh requested a review from skydoves as a code owner October 17, 2023 07:11
skydoves
skydoves approved these changes Oct 17, 2023
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution!

@skydoves skydoves merged commit 029a0c5 into skydoves:main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nohjunh @skydoves