feat: biometrics type #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akul-smallcase Wondering if this can be merged in? |
LonelyCpp
reviewed
Nov 17, 2024
Comment on lines
+105
to
+107
| if (pm.hasSystemFeature(PackageManager.FEATURE_FINGERPRINT)) { | ||
| promise.resolve("Fingerprint"); | ||
| } else if (pm.hasSystemFeature(PackageManager.FEATURE_FACE)) { |
There was a problem hiding this comment.
can you add some references to docs explaining how this works?
does this handles cases where the system has both features but the user has only enabled one of them?
|
Hey @kierancrown, sorry for the delayed response here - I don't get much time to look at PRs here. I've added a comment on the android implementation, would be great if you can answer |
There was a problem hiding this comment.
question: did you mean to commit these changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds biometrics type. So you can differentiate between FaceID and TouchID on iOS and Fingerprint and Face unlock on Android.
Tested on iPhone 15 PM and Google Pixel 8