-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: biometrics type #15
Open
kierancrown
wants to merge
10
commits into
smallcase:master
Choose a base branch
from
kierancrown:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9bb2cf6
feat: biometrics type
kierancrown b2460e9
fix: android states
kierancrown dccde01
fix: missing typo
kierancrown 27488ca
updated RN compatability
kierancrown 0bf0b79
chore: release 1.6.0
kierancrown d0ed8a5
chore: release 1.6.1
kierancrown a1c3144
feat(rn upgrade): add spec
kierancrown e37c460
chore: release 1.7.0
kierancrown 93c6d03
feat(rn upgrade): add spec
kierancrown d5d3cee
chore: release 1.8.0
kierancrown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#import <ReactCommon/ReactTurboModule.h> | ||
#import <ReactCommon/TurboModuleUtils.h> | ||
#import <React/RCTBridgeModule.h> | ||
#import <memory> | ||
|
||
namespace facebook { | ||
namespace react { | ||
|
||
class JSI_EXPORT NativeSimpleBiometricsSpecJSI : public ObjCTurboModule { | ||
public: | ||
NativeSimpleBiometricsSpecJSI(const ObjCTurboModule::InitParams ¶ms); | ||
|
||
// Declare the methods your module exports | ||
void canAuthenticate(jsi::Runtime &rt, std::function<void(jsi::Value)> &&resolve, std::function<void(jsi::Value)> &&reject); | ||
void requestBioAuth(jsi::Runtime &rt, const std::string &title, const std::string &subtitle, std::function<void(jsi::Value)> &&resolve, std::function<void(jsi::Value)> &&reject); | ||
void getBiometryType(jsi::Runtime &rt, std::function<void(jsi::Value)> &&resolve, std::function<void(jsi::Value)> &&reject); | ||
}; | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: did you mean to commit these changes? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "react-native-simple-biometrics", | ||
"version": "1.5.2", | ||
"version": "1.8.0", | ||
"description": "test", | ||
"main": "lib/commonjs/index", | ||
"module": "lib/module/index", | ||
|
@@ -35,34 +35,34 @@ | |
"ios", | ||
"android" | ||
], | ||
"repository": "https://github.com/smallcase/react-native-simple-biometrics", | ||
"repository": "https://github.com/kierancrown/react-native-simple-biometrics", | ||
"author": "smallcase <[email protected]> (https://github.com/smallcase)", | ||
"license": "MIT", | ||
"bugs": { | ||
"url": "https://github.com/smallcase/react-native-simple-biometrics/issues" | ||
"url": "https://github.com/kierancrown/react-native-simple-biometrics/issues" | ||
}, | ||
"homepage": "https://github.com/smallcase/react-native-simple-biometrics#readme", | ||
"homepage": "https://github.com/kierancrown/react-native-simple-biometrics#readme", | ||
"publishConfig": { | ||
"registry": "https://registry.npmjs.org/" | ||
}, | ||
"devDependencies": { | ||
"@arkweid/lefthook": "^0.7.7", | ||
"@babel/eslint-parser": "^7.18.2", | ||
"@commitlint/config-conventional": "^17.0.2", | ||
"@react-native-community/eslint-config": "^3.0.2", | ||
"@react-native-community/eslint-config": "^3.2.0", | ||
"@release-it/conventional-changelog": "^5.0.0", | ||
"@types/jest": "^28.1.2", | ||
"@types/react": "~17.0.21", | ||
"@types/react-native": "0.68.0", | ||
"@types/react-native": "^0.73.0", | ||
"commitlint": "^17.0.2", | ||
"eslint": "^8.4.1", | ||
"eslint-config-prettier": "^8.5.0", | ||
"eslint-plugin-prettier": "^4.0.0", | ||
"jest": "^28.1.1", | ||
"pod-install": "^0.1.0", | ||
"prettier": "^2.0.5", | ||
"react": "17.0.2", | ||
"react-native": "0.68.2", | ||
"react": "18.3.1", | ||
"react-native": "^0.76.0", | ||
"react-native-builder-bob": "^0.18.3", | ||
"release-it": "^15.0.0", | ||
"typescript": "^4.5.2" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some references to docs explaining how this works?
does this handles cases where the system has both features but the user has only enabled one of them?