Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr 9.7 → 9.8 for integration tests #1146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomascorthals
Copy link
Member

@thomascorthals thomascorthals commented Jan 30, 2025

The Solr 9.8 release broke some integration tests.

Things I had to chance to fix that:

  • The extraction module is no longer loaded by default, fixed by adding the SOLR_MODULES=extraction environment variable.
  • The patch file for solrconfig.xml is no longer compatible with previous versions, fixed by having a separate patch per version like we do for the schema.
  • 1 of the 32 sample documents in techproducts was removed, re-added the minimally required fields for the integration tests rather than checking the version in every integration test to determine if we must expect 32 or 31 docs.
  • For some reason the solr1 instance in the cloud test didn't start unless I added -z (--zk-host) to the command even though the other containers have no problem recognising ZK_HOST.
solr1  | Neither --zk-host or --solr-url parameters provided so assuming solr url is http://localhost:8983.
solr1  |
solr1  | ERROR: Server refused connection at: http://localhost:8983/solr/admin/info/system
solr1  |
solr1 exited with code 1

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (9cdf3dd) to head (f3c4087).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +0.01%     
==========================================
  Files         400      400              
  Lines       10524    10573      +49     
==========================================
+ Hits        10288    10337      +49     
  Misses        236      236              
Flag Coverage Δ
unittests 97.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant