[Admin] Use ui/button for the pagination component
#5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
elia
force-pushed
the
elia/admin/pagination-buttons
branch
from
c8fd963
to
9415b75
Compare
github-actions
bot
removed
changelog:solidus_backend
elia
force-pushed
the
elia/admin/pagination-buttons
branch
from
9415b75
to
50e4c84
Compare
rainerdema
approved these changes
Jul 27, 2023
elia
force-pushed
the
elia/admin/pagination-buttons
branch
2 times, most recently
from
5cecc98
to
89f3638
Compare
kennyadsl
approved these changes
Jul 27, 2023
3 tasks
|
@elia can you please rebase now? |
This is a preparatory to refactoring pagination component.
- Switch some ARIA attributes to semantic HTML - added `rel="prev"` and `rel="next"` - added text visible only to screen-readers - use aria-disabled
elia
force-pushed
the
elia/admin/pagination-buttons
branch
from
89f3638
to
5271787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on:
aria-disabledfor setting anchor buttons as disabled #5287ui/buttoncomponent #5284Please review only the last 4 commits 👀.
The implementation was simplified and now the responsibility of generating the links has been moved outside of the component. Generating the link turned out to be much simpler if don within the
products/indexcomponent. The pagination component won't render if both links are blank.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: