Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Use ui/button for the pagination component #5286

Merged
merged 4 commits into from
Jul 28, 2023
Merged

[Admin] Use ui/button for the pagination component #5286

merged 4 commits into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. Add the component helper to preview templates

    @elia
    elia committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7a9af58 View commit details
    Browse the repository at this point in the history

  2. Move the ui/table component preview to a template 

    This is a preparatory to refactoring pagination component.
    @elia
    elia committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c366577 View commit details
    Browse the repository at this point in the history

  3. Simplify the pagination component to just accept a prev and next link

    @elia
    elia committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    77f174f View commit details
    Browse the repository at this point in the history

  4. Reimplement the pagination as ui/button components 

    - Switch some ARIA attributes to semantic HTML
  - added `rel="prev"` and `rel="next"`
  - added text visible only to screen-readers
  - use aria-disabled
    @elia
    elia committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5271787 View commit details
    Browse the repository at this point in the history