Restrict sqlite3 gem to '~> 1.3', like ActiveRecord #5727
Conversation
They just released sqlite3 2.0.0, but ActiveRecord's sqlite3 adapter doesn't know about this yet, leading to conflicting sqlite3 gems in specs. This is probably a temporary fix until ActiveRecord learns the news.
github-actions
bot
added
the
changelog:repository
|
@mamhoff installer seems to need the same restriction
|
mamhoff
force-pushed
the
restrict-sqlite-to-1.x
branch
4 times, most recently
from
a67ec28
to
190bab4
Compare
The task itself is fine, as it inherits from Rails' app generator, which has the sqlite3 restriction: https://github.com/rails/rails/blob/main/railties/lib/rails/generators/database.rb#L19.
mamhoff
force-pushed
the
restrict-sqlite-to-1.x
branch
from
190bab4
to
e85fd4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5727 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 704 704
Lines 16757 16757
=======================================
Hits 14887 14887
Misses 1870 1870 ☔ View full report in Codecov by Sentry. |
tvdeyen
added
backport-v4.0
|
need to backport or all backport prs will fail |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
They just released sqlite3 2.0.0, but ActiveRecord's sqlite3 adapter doesn't know about this yet, leading to conflicting sqlite3 gems in specs.
This is probably a temporary fix until ActiveRecord learns the news.
See https://github.com/rails/rails/blob/main/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
and https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md