Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict sqlite3 gem to '~> 1.3', like ActiveRecord #5727

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Restrict sqlite3 gem to '~> 1.3', like ActiveRecord #5727

merged 2 commits into from
Apr 18, 2024

Commits on Apr 17, 2024

  1. Restrict sqlite3 gem to '~> 1.3', like ActiveRecord 

    They just released sqlite3 2.0.0, but ActiveRecord's sqlite3 adapter
doesn't know about this yet, leading to conflicting sqlite3 gems in
specs.

This is probably a temporary fix until ActiveRecord learns the news.
    @mamhoff
    mamhoff committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4319e17 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Restrict sqlite3 for the extension generator 

    The task itself is fine, as it inherits from
Rails' app generator, which has the sqlite3 restriction:
https://github.com/rails/rails/blob/main/railties/lib/rails/generators/database.rb#L19.
    @mamhoff
    mamhoff committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e85fd4c View commit details
    Browse the repository at this point in the history