Fix flaky spec with sleep #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's cumbersome to find elements by CSS selectors to click them, and the new admin has a few instances where we have no standalone label.
We need to wait for the JS to be loaded and connected here, otherwise the click doesn't do anything. There is an alternative fix for this in solidusio#5782
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 12, 2024
This will keep clicking the Filter button until the promotions menu appears. The problem this fixes is that a few milliseconds after navigation, the JS controller that switches the filter bar out might not have loaded. Alternative fixes here: solidusio#5782 solidusio#5783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a sleep statement to a spec. Alternatively, we can use #5782 .