Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky spec with sleep #5783

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix flaky spec with sleep #5783

merged 2 commits into from
Jun 12, 2024

Commits on Jun 12, 2024

  1. Allow Capybara to search for ARIA labels 

    It's cumbersome to find elements by CSS selectors to click them, and the
new admin has a few instances where we have no standalone label.
    @mamhoff
    mamhoff committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0c53451 View commit details
    Browse the repository at this point in the history

  2. Sleep for 1 second before clicking in order spec 

    We need to wait for the JS to be loaded and connected here, otherwise
the click doesn't do anything. There is an alternative fix for this in
solidusio#5782
    @mamhoff
    mamhoff committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7937d03 View commit details
    Browse the repository at this point in the history