-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for test_snmp_numpsu failure #14860
fix for test_snmp_numpsu failure #14860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fill the Approach Section of the PR and how/where it was verified? rest lgtm
@bpar9 have updated the PR with approach section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lğtm
PR test stuck. Let me close and re-open the PR. |
* fix for test_snmp_numpsu tc failure * Trigger Pipeline again
Cherry-pick PR to 202405: #15254 |
* fix for test_snmp_numpsu tc failure * Trigger Pipeline again
Description of PR
Summary:
test_snmp_numpsu
TC fails because of change instdout
output, observed in202405
&202311
.Fixes # (issue)
stdout_lines
will be use to fetch thenumpsus
value, if thestdout_lines
is empty / the value can't be typecasted; then in all scenarios TC wouldn't break, instead it will Error out gracefully. Samplestdout_lines
considered -Type of change
Back port request
Approach
What is the motivation for this PR?
Observed
test_snmp_psu
failing in202405
&202311
images due to change in thestdout
structure.How did you do it?
Earlier
stdout
output was simply getting typecasted, instead now it will usestdout_lines
& check its length, if it has a non-zero length, then it will pick the last element & try typecasting it;numpsus
count if exists, will always be the last element in the output.How did you verify/test it?
Run changes with
202405
&202311
images on aT0
setup and all of them passed.