replace piz with rc-zip #3012
replace piz with rc-zip #3012
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3012 +/- ##
==========================================
- Coverage 86.88% 86.87% -0.02%
==========================================
Files 136 136
Lines 15543 15550 +7
Branches 2637 2637
==========================================
+ Hits 13505 13509 +4
- Misses 1736 1739 +3
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luizirber
force-pushed
the
lirber/rc-zip
branch
from
bd9556b
to
0072045
Compare
What do we need in order to switch to 1.74? Is it just time, other packages, etc? |
We don't really have any rules, but I usually check
1.74 was released Nov 16th, which is fairly recent for distro standards/release cycles. 1.74 is also a pretty big release due to projections in opaque return types, which is exactly the feature that Maybe a good rule of thumb is checking what rust is available on the places we do packaging:
But these are fairly fast moving places =] More links:
|
luizirber
force-pushed
the
lirber/rc-zip
branch
from
7aaa1a8
to
37343ec
Compare
rc-zip can work on top of regular files (not memmap-ed files like piz).
It is also much easier to interact with.
Pending: more perf tests, but mem-wise I ran the command from #1909 (comment) and was seeing ~110MB max memory consumption.
Sadly, I think this will be draft for quite some time, it needs Rust 1.74 to compile =/
(it also broke wasm, need to do some splitting in
src/core/src/storage.rsto be able to compile a subset...)