Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added union method to HLL #3293

Merged

Conversation

LucaCappelletti94
Copy link
Contributor

  • While several other methods relative to the joint estimation were available, union estimation was not.
  • Added union method and relative test suite addition.

@LucaCappelletti94
Copy link
Contributor Author

@ctb this one should be more straightforward than PR #3292 as it does not introduce any new dependency.

@ctb
Copy link
Contributor

ctb commented Aug 15, 2024

@luizirber is this something you can review?

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.74%. Comparing base (bc22970) to head (ed67c55).
Report is 1 commits behind head on latest.

Files Patch % Lines
src/core/src/sketch/hyperloglog/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3293      +/-   ##
==========================================
- Coverage   86.75%   86.74%   -0.02%     
==========================================
  Files         137      137              
  Lines       15920    15923       +3     
  Branches     2728     2728              
==========================================
+ Hits        13812    13813       +1     
- Misses       1799     1801       +2     
  Partials      309      309              
Flag Coverage Δ
hypothesis-py 25.40% <ø> (ø)
python 92.37% <ø> (ø)
rust 62.64% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luizirber luizirber self-requested a review August 18, 2024 16:19
@luizirber luizirber merged commit 732fa36 into sourmash-bio:latest Aug 18, 2024
41 of 43 checks passed
@luizirber
Copy link
Member

Thanks @LucaCappelletti94 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants