-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hp, dayhoff options to manysketch #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @olgabot this looks great to me!
I note that it doesn't look like the manysketch docs need any changes. We still don't do translation, but that's ok ;)
I would like to ask you to change the PR title and description -
- right now it talks about
multisketch
notmanysketch
- the PR description should be updated to close How to do
manysketch
ondayhoff
,hp
moltypes? #337 when this is merged (i.e.Fixes #337
) and also should include a brief description of the new functionality.
If you'd like to add yourself to the authorship list in the README and pyproject.toml that would also be fine! No push either way - this may be too small a PR - but if you want to, please do!
Added a section about protein sketching with
Added! Let me know if more elaboration is needed.
By the time I finish #354, I'll probably have forgotten to add myself, so I'm doing it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! One suggestion for you to consider on documentation, but otherwise - go ahead and merge! (You should be able to merge now - if not, lmk.)
hi @olgabot is it ok if I update with my suggestion and then merge? I'm hoping to do a new release in the next day or two. |
Co-authored-by: C. Titus Brown <[email protected]>
Yes, totally fine to merge! |
Fixes #337 to add support for
dayhoff
andhp
moltypes tomanysketch
.To create sketches using the new functionality from protein sequences only (no translation from DNA sequences, sorry), the
dayhoff
,hp
, moltypes can be specified in the parameter string:Where
proteins.csv
looks like: