Chameleon controller implant (Clothing fast switch)

[beck-thompson]

About the PR

Added a chameleon controller implant that you can get in the standard chameleon bundle!

Why / Balance

Right now it takes a very long time to switch all the clothing one by one. This will allow you to still have fine grained control, but also quickly switch entire jobs in a matter of seconds. With the AI ever watching hopefully this lets antags using the chameleon clothing get a little more of an edge. It also uses your loadout from your profile, so you can make a decent amount of customization changes!

I'm planning on adding more stuff to this implant as well (E.g chameleon ID icon change) but wanted to keep it simple for the first PR.

Technical details

It is a lot... Most of the file changes are just UI stuff, the thing that you should probably focus on is ChameleonControllerSystem.cs and SharedStationSpawningSystem.cs. The loadout system is confusing so there is a lot of odd logic. Basically, I get the users profile, try to find if they have a loadout for a given job, if they do, use that as the clothing, if they don't and if they don't create a new one with the default!

profile.Loadouts.TryGetValue(jobProtoId, out var loadout);
loadout ??= new RoleLoadout(jobProtoId);
loadout.SetDefault(profile, session, _proto);

Then, I got through every slot and try to get the item stored for that slot with the new GetGearForSlot function.

var proto = _stationSpawningSystem.GetGearForSlot(loadout, slot.Name) ?? ((IEquipmentLoadout) startingGearPrototype).GetGear(slot.Name);

If their profile doesn't have anything for that slot, I see if there is any "starting gear" for that goes in the slot.

Media

2024-12-15.21-00-54.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑 Beck

• add: A chameleon controller implant that allows you to quickly switch between jobs clothing! Comes packaged in the chameleon kit.

[github-actions]

RSI Diff Bot; head commit 5d6947e merging into b7d3c08
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Actions/Implants/implants.rsi

State	Old	New	Status
chameleon			Added

Edit: diff updated after 5d6947e

[Everturning]

The UI looks really good. it seems to work well in the video too.

[Aeshus]

Thanks for the PR!

It looks pretty good, though I just have some stylistic issues, you should probably be using FancyWindow, and you should see if you can just use the SetOutfitCommand code or maybe integrate the two to share implementations.

[Aeshus]

I noticed there's a lot of shared/duplicate code between this and the SetOutfitCommand

https://github.com/space-wizards/space-station-14/blob/782a2978f0b34f9c74b209a072a175e84e645b24/Content.Server/Administration/Commands/SetOutfitCommand.cs

It might be useful to look or even directly integrate the two as they do a very similar job.

[beck-thompson]

We talked about this on discord, the issue right now is that although there is a decent amount of duplicated code / similar code, the it would actually be relatively difficult to combine the functions. The big issue is that the set outfit command doesn't go off of jobs and is based off StartingGearPrototype which kind of messes stuff up. I might be able to somehow combine them partially but I don't really think the complexity would decrease that much unfortunately 😔

If someone with more experience with loadouts could give some pointers or anyone has ideas, I'll totally combine them but for now I'm just going to leave it separate.

[southbridge-fur]

I love this. My one issue would be folks meta gaming people with default outfits, but that remains to be seen.

[beck-thompson]

I love this. My one issue would be folks meta gaming people with default outfits, but that remains to be seen.

I actually did think of this! It will use your loadout that you have for the job so everyone can customize it. Hopefully it wont be too much of an issue

[ArtisticRoomba]

I love this. My one issue would be folks meta gaming people with default outfits, but that remains to be seen.

Absolutely hilarious how absurd metagaming can be sometimes.

"You've been going in and out of maints with the most basic fit of all time. I'm arresting you"

[TeenSarlacc]

Absolutely hilarious how absurd metagaming can be sometimes.

"You've been going in and out of maints with the most basic fit of all time. I'm arresting you"

gotta make sure all the antags redtext, what do you mean this is a role-playing game?????

[Pumkin69]

this is sooo cool actually amazing idea

[beck-thompson]

Tested with the new PDA and it works!

Review Addressed

[Aeshus]

Thanks for addressing the review a month ago!

I just had some nitpicks (of course, it's me) and some questions.

Imagine my shock when a maintainer made mistakes 3 months ago.

Also, any thoughts on renaming the "Chameleon Controller" to something else, like "Chameleon Tailor/Outfitter"? "Chameleon Controller" sounds too generic and doesn't make it painfully obvious what it does.

I'll probably re-review this again after you address these changes, in which I'll look more into the UI and whatever is going on with the outfit code.

Anyways, have fun trying to remember what this PR was doing!

[Aeshus]

question: I also noticed that many of the other implant actions have a set number of charges. Do you think unlimited would be fine balancing-wise?

[beck-thompson]

Looking at the usage rate of chameleon clothing (Its really low) yeah I don't think is an issue at all! This was never intended to be a specific amount of uses

[beck-thompson]

As another note, the reason why its called "Chameleon Controller" instead of something super specific is because I have a lot of other stuff planned! This is only the first PR of a few. Some other stuff I'm thinking of adding:
1.) Only allow chameleon clothing to be changed if your wearing the implant
2.) Change job icons / agent ID cards to match
3.) Update mindshield status when you have the mindshield implant when choosing a command / security outfit
3.) Integrate with the voice mask to also randomly swap names

I agree, the name isn't the best, but I don't want to make it super specific to clothing because of all that!

[Everturning]

1.) Only allow chameleon clothing to be changed if your wearing the implant
2.) Change job icons / agent ID cards to match
3.) Update mindshield status when you have the mindshield implant when choosing a command / security outfit
3.) Integrate with the voice mask to also randomly swap names

i disagree with almost everything on this list. here's why:
1: There are a variety of non-job-specific clothing items one may seek to imitate. This implant, while useful, should not be mandatory.
2: While I am not opposed to the idea, I believe a diligent player should be able to remember their agent ID themself and that this is not needed.
3: The wording here is unclear, but it appears to mean either "when you have a mindshield implant, this will give you the mindshield effect" or "when you select a command/security role, you will look like you have a mindshield". The issue with the first is that if you have a mindshield implant, you should always get the effect. The issue with the second is, if you look like you have a mindshield when you don't as these roles, what is the point of the mindshield then? Please clarify the wording.
4: I really just don't think this is needed. The players can do this just fine.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.