Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chameleon controller implant (Clothing fast switch) #33887
base: master
Are you sure you want to change the base?
Chameleon controller implant (Clothing fast switch) #33887
Changes from 3 commits
236c7a0
3bfc92c
4462c1e
f753ffb
8f859e4
5d6947e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there's a lot of shared/duplicate code between this and the SetOutfitCommand
https://github.com/space-wizards/space-station-14/blob/782a2978f0b34f9c74b209a072a175e84e645b24/Content.Server/Administration/Commands/SetOutfitCommand.cs
It might be useful to look or even directly integrate the two as they do a very similar job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this on discord, the issue right now is that although there is a decent amount of duplicated code / similar code, the it would actually be relatively difficult to combine the functions. The big issue is that the set outfit command doesn't go off of jobs and is based off
StartingGearPrototype
which kind of messes stuff up. I might be able to somehow combine them partially but I don't really think the complexity would decrease that much unfortunately 😔If someone with more experience with loadouts could give some pointers or anyone has ideas, I'll totally combine them but for now I'm just going to leave it separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I also noticed that many of the other implant actions have a set number of charges. Do you think unlimited would be fine balancing-wise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the usage rate of chameleon clothing (Its really low) yeah I don't think is an issue at all! This was never intended to be a specific amount of uses