Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the bounding_box in inverse transforms #498

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nden
Copy link
Collaborator

@nden nden commented May 14, 2024

Fixes #496

This is a fix similar in spirit to #497 though it uses methods of modeling.ModelBoundingBox .

@nden nden requested a review from a team as a code owner May 14, 2024 16:33
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 87.04%. Comparing base (eb9d316) to head (926123b).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
gwcs/tests/conftest.py 30.00% 14 Missing ⚠️
gwcs/wcs.py 92.53% 5 Missing ⚠️
gwcs/api.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   87.28%   87.04%   -0.24%     
==========================================
  Files          22       21       -1     
  Lines        3821     3891      +70     
==========================================
+ Hits         3335     3387      +52     
- Misses        486      504      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden
Copy link
Collaborator Author

nden commented May 14, 2024

@bmorris3 Do you mind testing this PR with your code?
Since this changes the functionality, there are a number of failures in the jwst pipeline. I'll need to address them before this is merged or make this the non-default behavior.

@nden nden added this to the 0.22 milestone May 14, 2024
@nden nden requested a review from Cadair May 17, 2024 15:52
@nden
Copy link
Collaborator Author

nden commented May 17, 2024

@Cadair Can you take a look at this PR and see if it's OK for sun related code?
Note that enforcing the bounding_box on the inverse transform now works and this can change results. If reproducing the bug is necessary, a parameter should be passed with_bounding_box=False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in treatment of pixel_bounds
1 participant