-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clone viewer tool #74
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 95.04% 95.10% +0.06%
==========================================
Files 32 32
Lines 1393 1431 +38
==========================================
+ Hits 1324 1361 +37
- Misses 69 70 +1 ☔ View full report in Codecov by Sentry. |
* NOTE: known bug with layer options reverting when adding to any new viewer (was not introduced here, but this definitely exposes it more readily)
61572bc
to
b1e807e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great. LGTM.
@@ -308,7 +308,8 @@ def vue_period_double(self, *args): | |||
self.period *= 2 | |||
|
|||
def _check_if_phase_viewer_exists(self, *args): | |||
self.phase_viewer_exists = self.phase_viewer_id in self.app.get_viewer_ids() | |||
viewer_base_refs = [id.split('[')[0] for id in self.app.get_viewer_ids()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with assuming there aren't other square brackets in the viewer ID. Just leaving a comment here to hopefully remind us both that, going forward, we're assuming that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this is very much assuming we always stick to these syntax rules... but if we ever want viewer renaming, we can always move these things into attributes rather than parsing the viewer name itself, I just don't want to overengineer it until then.
Co-authored-by: Brett M. Morris <[email protected]>
This PR implements a toolbar tool capable of cloning the current viewer (keeping axes limits, data loaded/visible, and plot options - except for bug noted below) in a way that still works seemlessly with the ephemeris plugin.
Screen.Recording.2023-12-12.at.2.03.09.PM.mov
Screen.Recording.2023-12-12.at.2.05.09.PM.mov
NOTE: known bug with layer options reverting when adding to any new viewer (was not introduced here, but this definitely exposes it more readily)
TODO: