clone viewer tool #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 95.04% 95.10% +0.06%
==========================================
Files 32 32
Lines 1393 1431 +38
==========================================
+ Hits 1324 1361 +37
- Misses 69 70 +1 ☔ View full report in Codecov by Sentry. |
* NOTE: known bug with layer options reverting when adding to any new viewer (was not introduced here, but this definitely exposes it more readily)
kecnry
force-pushed
the
clone-viewer-tool
branch
from
61572bc
to
b1e807e
Compare
bmorris3
approved these changes
Dec 18, 2023
| @@ -308,7 +308,8 @@ def vue_period_double(self, *args): | |||
| self.period *= 2 | |||
|
|
|||
| def _check_if_phase_viewer_exists(self, *args): | |||
| self.phase_viewer_exists = self.phase_viewer_id in self.app.get_viewer_ids() | |||
| viewer_base_refs = [id.split('[')[0] for id in self.app.get_viewer_ids()] | |||
There was a problem hiding this comment.
I'm OK with assuming there aren't other square brackets in the viewer ID. Just leaving a comment here to hopefully remind us both that, going forward, we're assuming that.
There was a problem hiding this comment.
yep, this is very much assuming we always stick to these syntax rules... but if we ever want viewer renaming, we can always move these things into attributes rather than parsing the viewer name itself, I just don't want to overengineer it until then.
Co-authored-by: Brett M. Morris <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a toolbar tool capable of cloning the current viewer (keeping axes limits, data loaded/visible, and plot options - except for bug noted below) in a way that still works seemlessly with the ephemeris plugin.
Screen.Recording.2023-12-12.at.2.03.09.PM.mov
Screen.Recording.2023-12-12.at.2.05.09.PM.mov
NOTE: known bug with layer options reverting when adding to any new viewer (was not introduced here, but this definitely exposes it more readily)
TODO: