Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Clean Up (Removals) #317

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

mfixstsci
Copy link
Collaborator

  • Removing DS_Store
  • numpy docs and coverage badge
  • Adding .DS_Store to gitignore file as well

addresses #310, #315, #311, #306

@mfixstsci
Copy link
Collaborator Author

@pllim this addresses a couple of issues and the CI is passing. Would you be able to do a quick review? @Witchblade101 is out of town on vacation and I don't want this to go stale.

@pllim
Copy link

pllim commented Aug 21, 2023

Err... did you try a rebase?

git fetch upstream master
git rebase upstream/master

@pllim pllim mentioned this pull request Aug 21, 2023
@mfixstsci
Copy link
Collaborator Author

mfixstsci commented Aug 22, 2023

Err... did you try a rebase?

git fetch upstream master
git rebase upstream/master

Hey @pllim I have not with this branch. I believe I did try to rebase #319 which may have caused the issue with the history. This one looks fine, right?

@pllim
Copy link

pllim commented Aug 22, 2023

Move this to "docs" requirement

"numpydoc>=1.1.0",

@pllim
Copy link

pllim commented Aug 22, 2023

This one looks fine, right?

I cannot tell. It has merge commits.

@mfixstsci
Copy link
Collaborator Author

This one looks fine, right?

I cannot tell. It has merge commits.

I see the merge commits from master which are incorporating the CI changes @zacharyburnett made to get the tests passing. Besides that the history looks chronological.

@pllim
Copy link

pllim commented Aug 23, 2023

I'll have to trust your judgement on this one since you are the maintainer after all. Thanks for checking!

@mfixstsci
Copy link
Collaborator Author

@Witchblade101 this one is ready for review.

Copy link
Collaborator

@Witchblade101 Witchblade101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mfixstsci mfixstsci merged commit 0c4711a into spacetelescope:master Sep 8, 2023
3 checks passed
@mfixstsci mfixstsci deleted the update-repo-removals branch September 8, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants