-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inverse linearity for CRDS and add uri/filename consistency checks. #296
Fix inverse linearity for CRDS and add uri/filename consistency checks. #296
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 94.24% 95.32% +1.07%
==========================================
Files 4 4
Lines 139 171 +32
==========================================
+ Hits 131 163 +32
Misses 8 8
☔ View full report in Codecov by Sentry. |
Note that tis will create failures in the |
0f0c406
to
ba41bfa
Compare
A bug report came in showing CRDS did not like the reftype-uri mismatch. These tests test for that and uri/filename consistency
ba41bfa
to
23645e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #292
Closes #293
This PR fixes the inverse linearity issues persisting in CRDS. Moreover, it adds checks so that this cannot occur again for CRDS, and consistency checks for naming between the filenames, schema uris, and tag uris.
Checklist
CHANGES.rst
under the corresponding subsection