Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverse linearity for CRDS and add uri/filename consistency checks. #296

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 20, 2023

Closes #292
Closes #293

This PR fixes the inverse linearity issues persisting in CRDS. Moreover, it adds checks so that this cannot occur again for CRDS, and consistency checks for naming between the filenames, schema uris, and tag uris.

Checklist

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 20, 2023 14:59
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.07 🎉

Comparison is base (a9203cf) 94.24% compared to head (ba41bfa) 95.32%.

❗ Current head ba41bfa differs from pull request most recent head 23645e0. Consider uploading reports for the commit 23645e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   94.24%   95.32%   +1.07%     
==========================================
  Files           4        4              
  Lines         139      171      +32     
==========================================
+ Hits          131      163      +32     
  Misses          8        8              
Impacted Files Coverage Δ
tests/test_integration.py 96.00% <100.00%> (+1.00%) ⬆️
tests/test_manifest.py 100.00% <100.00%> (ø)
tests/test_schemas.py 94.26% <100.00%> (+1.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson
Copy link
Collaborator Author

Note that tis will create failures in the roman_datamodels due to the renamed inverselinearity schema

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit c46d5a1 into spacetelescope:main Jul 20, 2023
10 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/crds_inverse_linearity branch July 20, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Inverse Linearity RefType Discontinuity Inverse linearity schema incompatible with CRDS
2 participants