Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-159: Create the flux step schema #395

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

stscieisenhamer
Copy link
Contributor

@stscieisenhamer stscieisenhamer commented Mar 25, 2024

Resolves RAD-159

Related PRs:

This PR completes the schema setup for the new romancal FluxStep by adding it to the cal_step schema.

Checklist

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (0fb1239) to head (c7aeb4d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           4        4           
  Lines         195      195           
=======================================
  Hits          186      186           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stscieisenhamer stscieisenhamer changed the title RCAL-800 Create the flux step schema RCAL-800: Create the flux step schema Mar 25, 2024
@stscieisenhamer stscieisenhamer requested a review from a team as a code owner March 25, 2024 02:59
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should wait on merging until this is discussed at the RAD meeting.

@PaulHuwe
Copy link
Collaborator

Resolves #394

@PaulHuwe PaulHuwe merged commit 0c39024 into spacetelescope:main Mar 29, 2024
13 checks passed
@nden nden added this to the Build 14 milestone Mar 29, 2024
@nden nden changed the title RCAL-800: Create the flux step schema RAD-159: Create the flux step schema Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants