-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-800: Set flux step status for each input #1160
RCAL-800: Set flux step status for each input #1160
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
- Coverage 76.76% 76.73% -0.03%
==========================================
Files 107 107
Lines 7096 7101 +5
==========================================
+ Hits 5447 5449 +2
- Misses 1649 1652 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Do you think there are cases where we want the pipeline to continue when we have failed to flux calibrate? My sense is that if we try to flux calibrate and fail something has gone badly wrong and we don't want to just continue and mark as skipped, but maybe I'm missing some case where that would be the desired behavior?
Sorry for the late reply. I agree that the exception catching may be a bit broad. My intent was to only continue on for the condition of units not being able to convert. How about if the unit checking it tightened, so that it only checks if the data is already in flux units. Otherwise, if the data is not in the expected DN/s units, fail completely. |
That sounds like a good approach to me. |
aed8b0f
to
e5e7bc6
Compare
e5e7bc6
to
5f2a0bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Presumably it will break the regression tests, though, and we'll need to do an okify; are you able to do that?
In principle I can and will attempt it. |
Looks good, yup, go ahead and update and okify. |
Resolves RCAL-800
Related PRs:
This PR sets the step completion status for each input model to FluxStep.
Checklist
CHANGES.rst
under the corresponding subsection