Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-155: Add 'basic' schema to 'wfi_mosaic' #328

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Conversation

nden
Copy link
Collaborator

@nden nden commented Mar 7, 2024

Resolves RCAL-nnnn

Closes #

The changes in this PR correspond to RAD-155 changes in spacetelescope/rad#390.
pyproject should be updated before merging

Checklist

@nden nden requested a review from a team as a code owner March 7, 2024 13:05
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (087a60d) to head (a42188a).
Report is 6 commits behind head on main.

❗ Current head a42188a differs from pull request most recent head 355494e. Consider uploading reports for the commit 355494e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   97.56%   97.51%   -0.06%     
==========================================
  Files          30       32       +2     
  Lines        2788     2972     +184     
==========================================
+ Hits         2720     2898     +178     
- Misses         68       74       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/roman_datamodels/maker_utils/_common_meta.py Outdated Show resolved Hide resolved
src/roman_datamodels/maker_utils/_datamodels.py Outdated Show resolved Hide resolved
@nden nden force-pushed the rad-155 branch 2 times, most recently from a42188a to 2b779be Compare March 8, 2024 11:45
@nden
Copy link
Collaborator Author

nden commented Mar 8, 2024

@PaulHuwe Thanks for the review. This is ready now for final review.

@nden nden mentioned this pull request Mar 8, 2024
6 tasks
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nden nden added the Level3 label Mar 12, 2024
@nden nden added this to the 24Q3_B14 milestone Mar 12, 2024
@nden nden merged commit 26c0b37 into spacetelescope:main Mar 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants