fix: show disconnection on UI web socket #1983 #2005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full and abrupt disconnections
…on from the server
sahell0x
changed the title
Comment on lines
+553
to
+598
| if (wsData) { | ||
| let msgListner: any = wsData.msgListner; | ||
|
|
||
| wsData.messages.unshift({ | ||
| data: `Disconnected from ${url}`, | ||
|
|
||
| transmitter: "disconnector", | ||
|
|
||
| timestamp: formatTime(new Date()), | ||
|
|
||
| uuid: uuidv4(), | ||
| }); | ||
|
|
||
| wsData.status = "disconnected"; | ||
|
|
||
| webSocketDataMap.set(tabId, wsData); | ||
|
|
||
| if (msgListner) { | ||
| msgListner(); | ||
| } | ||
| } | ||
|
|
||
| return webSocketDataMap; | ||
| }); | ||
|
|
||
| notifications.error("Connection Lost"); | ||
|
|
||
| console.log("abrupt disconnection"); | ||
| }); | ||
|
|
||
| const closeListen = await once( | ||
| `ws_graceful_disconnect_${tabId}`, | ||
| (event) => { | ||
| webSocketDataStore.update((webSocketDataMap) => { | ||
| const wsData = webSocketDataMap.get(tabId); | ||
|
|
||
| if (wsData) { | ||
| let msgListner: any = wsData.msgListner; | ||
|
|
||
| wsData.messages.unshift({ | ||
| data: `Disconnected from ${url}`, | ||
|
|
||
| transmitter: "disconnector", | ||
|
|
||
| timestamp: formatTime(new Date()), | ||
|
|
There was a problem hiding this comment.
these two ERR and Close listeners should be not required, should be only handled with current listener using parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue : #1983
added listners for onClose and onError to detect disconnection in connect_websocket function now UI has mechanism to show disconnections and set status to disconnected if there is disconnection in web-socket.
on graceful disconnection
Screencast.from.2024-11-11.21-56-52.webm
on abrupt disconnection
Screencast.from.2024-11-11.22-14-21.webm
What type of PR is this? (check all applicable)
Have you tested locally?
Added tests?
Added to documentation?