More return types

spatie · Jan 5, 2016 · 2675051 · 2675051
1 parent 372af63
commit 2675051
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 13 deletions.
diff --git a/src/RobotsMiddleware.php b/src/RobotsMiddleware.php
@@ -13,7 +13,7 @@ class RobotsMiddleware
      */
     protected $response;
 
-    public function handle(Request $request, Closure $next)
+    public function handle(Request $request, Closure $next) : Response
     {
         $this->response = $next($request);
 
@@ -34,7 +34,7 @@ public function handle(Request $request, Closure $next)
         throw new InvalidIndexRule('An indexing rule needs to return a boolean or a string');
     }
 
-    protected function responseWithRobots(string $contents)
+    protected function responseWithRobots(string $contents) : Response
     {
         $this->response->header('x-robots-tag', $contents);
 

diff --git a/tests/TestMiddlewares/CustomTestMiddleware.php b/tests/TestMiddlewares/CustomTestMiddleware.php
@@ -7,10 +7,7 @@
 
 class CustomTestMiddleware extends RobotsMiddleware
 {
-    /**
-     * @return string|bool
-     */
-    protected function shouldIndex(Request $request)
+    protected function shouldIndex(Request $request) : string
     {
         if ($request->segment(1) === 'custom-tag') {
             return 'nofollow';

diff --git a/tests/TestMiddlewares/InvalidTestMiddleware.php b/tests/TestMiddlewares/InvalidTestMiddleware.php
@@ -7,9 +7,6 @@
 
 class InvalidTestMiddleware extends RobotsMiddleware
 {
-    /**
-     * @return string|bool
-     */
     protected function shouldIndex(Request $request) : array
     {
         return [];

diff --git a/tests/TestMiddlewares/SimpleTestMiddleware.php b/tests/TestMiddlewares/SimpleTestMiddleware.php
@@ -7,10 +7,7 @@
 
 class SimpleTestMiddleware extends RobotsMiddleware
 {
-    /**
-     * @return string|bool
-     */
-    protected function shouldIndex(Request $request)
+    protected function shouldIndex(Request $request) : bool
     {
         return $request->segment(1) !== 'go-away';
     }