Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing custom IRIs for NoAssertionElement and NoneElement (for owl:sameAs) #883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 13, 2024

Find this during diagram update for SpdxOrganization,
do the custom IRI of NoAssertionElement and NoneElement missing in the spec's model description?

Currently these are IRIs of NoAssertionElement, NoneElement, NoAssertionLicense and NoneLicense in the digrams:

Core
Licensing

These are "custom" or "simplified" IRIs for those individuals.

However, there are differences between the spec and the diagram:

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added Profile:Core Core Profile and related matters publishing Dependency for publishing final version of spec labels Sep 13, 2024
@bact bact added this to the 3.0.1 milestone Sep 13, 2024
@zvr
Copy link
Member

zvr commented Sep 13, 2024

No, there is no need for custom IRIs for these individuals.

Every class, property, individual gets an automatic IRI. These are perfectly fine for almost all cases.
In this case it's https://spdx.org/rdf/3.0.1/terms/Core/NoneElement and it's fine.

We've added custom IRIs to individual license elements to have a something simpler than mentioning ExpandedLicensing. These two are the exception, not the rule.
So, besides the automatically generated https://spdx.org/rdf/3.0.1/terms/ExpandedLicensing/NoneLicense there is also https://spdx.org/rdf/3.0.1/terms/Licensing/None and they are defined to be the same.

@bact
Copy link
Collaborator Author

bact commented Sep 13, 2024

Thanks.

Then, do we need to update the diagram?

Core

@goneall
Copy link
Member

goneall commented Sep 24, 2024

Based on the tech call on 24 Sept 2024: We will move this to 3.1 - it has no breaking change and the inconsistency between the model and the diagram is resolved with removing individuals from the diagram

@goneall goneall modified the milestones: 3.0.1, 3.1 Sep 24, 2024
@zvr
Copy link
Member

zvr commented Sep 25, 2024

I still maintain that this is not needed and should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Core Core Profile and related matters publishing Dependency for publishing final version of spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants