Add node registration entry alias example #231
Conversation
kfox1111
requested review from
ajessup,
Andres-GC,
evan2645,
mchurichi,
sanderson042 and
umairmkhan
as code owners
|
✔️ Deploy Preview for spiffe ready! 🔨 Explore the source changes: 0a55a95 🔍 Inspect the deploy log: https://app.netlify.com/sites/spiffe/deploys/6182f1b7b4ad0c0008c1d654 😎 Browse the preview: https://deploy-preview-231--spiffe.netlify.app |
There was a problem hiding this comment.
Thank you @kfox1111! This looks good to me
@sanderson042 is the formatting alright?
|
@kfox1111 would you mind adding a DCO to this commit and force-pushing back to the branch? It can be added with git flag https://github.com/spiffe/spiffe.io/pull/231/checks?check_run_id=4096274127 https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin |
|
Yeah. I can do that... I had just used the github interface to quickly prepare the change. Its a lot more complicated to do the signoff. Oh well. |
Signed-off-by: Kevin Fox <[email protected]>
|
Ok. Should be fixed. |
| For example: | ||
|
|
||
| ``` | ||
| spire-server entry create -node -spiffeID spiffe://devvm.local/mynodealias -selector tpm:pub_hash:xxxxx |
There was a problem hiding this comment.
@sanderson042 what do you think about a more widely used selector here? Perhaps aws_iid:tag:<TAG_NAME>:<TAG_VALUE>
There was a problem hiding this comment.
@kfox1111 heya 👋 just wanted to say that Evan's suggestion looks good to me, and since this is supposed to be an example we could even leave the templating stuff out and use something like aws_iid:tag:tier:frontend, we can then get this merged in 💪
No description provided.