chore: share the test util get_absolute_path

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(infra): add error variant for file not found on get path #2169
• chore(infra): share get_absolute_path infra util with snapi test utils #2075
• chore(infra): move get_absolute_path function to infra_utils #2074
• feat: create infra utils crate #2073
• chore: share the test util path_in_resources #2052
• chore: share the test util get_absolute_path #2026 👈 (View in Graphite)
• chore: move nonce manager struct near the impl block #2020
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (e3165c4) to head (e127c69).
Report is 383 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2026       +/-   ##
===========================================
+ Coverage   40.10%   77.11%   +37.01%     
===========================================
  Files          26      372      +346     
  Lines        1895    39702    +37807     
  Branches     1895    39702    +37807     
===========================================
+ Hits          760    30618    +29858     
- Misses       1100     6805     +5705     
- Partials       35     2279     +2244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ArniStarkware]

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

---

crates/papyrus_config/Cargo.toml line 26 at r1 (raw file):

lazy_static.workspace = true
papyrus_test_utils.workspace = true
starknet_api.workspace = true

@Itay-Tsabary-Starkware - Correct me if I am wrong, but you are now in charge of this crate

As discussed, starknet_api should be at the bottom of crate hierarchies. The config crate should also be low in the hierarchy, which might be problematic if we have an inheritance here.

Code quote:

starknet_api.workspace = true

[Itay-Tsabary-Starkware]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

---

crates/papyrus_config/Cargo.toml line 26 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

@Itay-Tsabary-Starkware - Correct me if I am wrong, but you are now in charge of this crate

As discussed, starknet_api should be at the bottom of crate hierarchies. The config crate should also be low in the hierarchy, which might be problematic if we have an inheritance here.

Right. IMO this is accetpable for the time being, but the more thought I put into this the more it seems we need this in a desginated util crate with this function as production code. You can see there are plenty of instances where the code opens files using relative paths in an unchecked manner.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ArniStarkware]

Merge activity

• Nov 14, 5:47 AM EST: A user merged this pull request with Graphite.