chore(infra): move get_absolute_path function to infra_utils

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(infra): add error variant for file not found on get path #2169
• chore(infra): share get_absolute_path infra util with snapi test utils #2075
• chore(infra): move get_absolute_path function to infra_utils #2074 👈 (View in Graphite)
• feat: create infra utils crate #2073
• chore: share the test util path_in_resources #2052
• chore: share the test util get_absolute_path #2026
• chore: move nonce manager struct near the impl block #2020
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (e3165c4) to head (eb4e92e).
Report is 510 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/infra_utils/src/path.rs	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2074       +/-   ##
===========================================
+ Coverage   40.10%   77.46%   +37.35%     
===========================================
  Files          26      386      +360     
  Lines        1895    40473    +38578     
  Branches     1895    40473    +38578     
===========================================
+ Hits          760    31351    +30591     
- Misses       1100     6815     +5715     
- Partials       35     2307     +2272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.473 ms 34.514 ms 34.558 ms]
change: [-4.7403% -3.1596% -1.7857%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[Itay-Tsabary-Starkware]

Reviewed 3 of 5 files at r1, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/infra_utils/src/path.rs line 6 at r1 (raw file):

// TODO(Tsabary/ Arni): consolidate with other get_absolute_path functions.
/// Returns the absolute path from the project root.
pub fn get_absolute_path(relative_path: &str) -> PathBuf {

I think the name and doc should reflect the relative path is from the project directory. Perhaps even state explicitly what is the returned directory.
Also consider (optional) to split into two functions: obtaining the current path, and joining with the relative path.

Code quote:

// TODO(Tsabary/ Arni): consolidate with other get_absolute_path functions.
/// Returns the absolute path from the project root.
pub fn get_absolute_path(relative_path: &str) -> PathBuf {

---

crates/infra_utils/src/path.rs line 12 at r1 (raw file):

        .map(|dir| PathBuf::from(dir).join("../.."))
        // If `CARGO_MANIFEST_DIR` isn't set, fall back to the current working directory
        .unwrap_or_else(|_| env::current_dir().expect("Failed to get current directory"));

For a different pr:

ChatGPT suggested using env::current_exe(), are you familiar with it?

use std::env;
use std::path::PathBuf;

fn get_project_path() -> PathBuf {
    if let Ok(manifest_dir) = env::var("CARGO_MANIFEST_DIR") {
        return PathBuf::from(manifest_dir);
    }

    let exe_path = env::current_exe().expect("Failed to get current executable path");
    let exe_dir = exe_path.parent().expect("Failed to get executable directory");

    if exe_dir.ends_with("debug") || exe_dir.ends_with("release") {
        return exe_dir.parent().unwrap().parent().unwrap().to_path_buf();
    }

    env::current_dir().expect("Failed to get current working directory")
}

fn main() {
    let project_path = get_project_path();
    println!("Project path: {}", project_path.display());
}

Code quote:

    let base_dir = env::var("CARGO_MANIFEST_DIR")
        // Attempt to get the `CARGO_MANIFEST_DIR` environment variable and convert it to `PathBuf`.
        // Ascend two directories ("../..") to get to the project root.
        .map(|dir| PathBuf::from(dir).join("../.."))
        // If `CARGO_MANIFEST_DIR` isn't set, fall back to the current working directory
        .unwrap_or_else(|_| env::current_dir().expect("Failed to get current directory"));

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.266 ms 34.298 ms 34.335 ms]
change: [-4.0309% -2.4181% -1.0381%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here