Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use deref in account tx for removal of builerplate #236

Closed
wants to merge 1 commit into from
Closed

refactor: use deref in account tx for removal of builerplate #236

wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 31, 2024 •
edited
Loading

I tried searching the code for all instances where the deref will be useful and address them.

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Jul 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review July 31, 2024 13:25
ArniStarkware
ArniStarkware commented Jul 31, 2024
View reviewed changes
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+reviewer:@yair-starkware

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @MohammadNassar1, @Yael-Starkware, and @yair-starkware)

MohammadNassar1
MohammadNassar1 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware and @yair-starkware)

This was referenced Aug 1, 2024
Merged
Merged
@ArniStarkware
Copy link
Contributor Author

From @yair-starkware:

This is not a classic use case of deref, and while I'm not sure I'm against it, I'm also not sure I'm for it.

I think this should not be the path we go with.

@ArniStarkware
Copy link
Contributor Author

As discussed, this technology is abusable.

@ArniStarkware ArniStarkware deleted the arni/refactor/account_tx_wrapper/deref_in_account_txs branch August 4, 2024 06:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MohammadNassar1 MohammadNassar1 MohammadNassar1 approved these changes

@Yael-Starkware Yael-Starkware Awaiting requested review from Yael-Starkware

@yair-starkware yair-starkware Awaiting requested review from yair-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArniStarkware @MohammadNassar1