chore: refactor invoke as wrapper

[ArniStarkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

For internal deploy account transaction, the data is inseparable from the implementation.
The data of IntrnalInvokeTransaction and of InvokeTransaction (on the blockifier) is duplicated.

What is the new behavior?

• Refactor InvokeTransaction as a wrapper of IntrnalInvokeTransaction while keeping the implementation.

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[ArniStarkware]

• chore: define try from snapi executable transaction for account tx #526
• chore: refactor invoke as wrapper #93 👈
• chore: refactor deploy account as wrapper #92
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[MohammadNassar1]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)

---

crates/blockifier/src/transaction/transactions.rs line 495 at r3 (raw file):

        let common_fields = CommonAccountFields {
            transaction_hash: self.tx.tx_hash,
            version: self.tx.tx.version(),

and the same for the other fields pls

Suggestion:

self.tx.version()

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @MohammadNassar1)

---

crates/blockifier/src/transaction/transactions.rs line 495 at r3 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

and the same for the other fields pls

Done.

[MohammadNassar1]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

Reviewed 1 of 3 files at r1, 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

crates/gateway/src/utils.rs line 149 at r5 (raw file):

        },
        AccountTransaction::DeployAccount(tx) => tx.contract_address(),
        AccountTransaction::Invoke(tx) => match &tx.tx() {

Please review this change from the base commit.

Code quote:

 AccountTransaction::Invoke(tx) => match &tx.tx() {

[dafnamatsry]

Reviewed 3 of 4 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[MohammadNassar1]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Merge activity

• Aug 20, 8:36 AM EDT: @ArniStarkware started a stack merge that includes this pull request via Graphite.
• Aug 20, 8:38 AM EDT: Graphite rebased this pull request as part of a merge.
• Aug 20, 8:48 AM EDT: @ArniStarkware merged this pull request with Graphite.