Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move required classes out of \App into package; fix namespacing + class names #45

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

dave-mills
Copy link
Member

PR to fix issues with class names and name-spacing from the custom / team xlsform template classes.

Copy link

what-the-diff bot commented Dec 3, 2024

PR Summary

  • Introduced New Widget Files:

    • available-templates-widget.blade.php - This new widget will be able to display all the existing templates of ODK and detail about them.
    • custom-odk-templates-widget.blade.php - This new widget will be able to display custom templates that are created specifically for the user's team.
  • Enhanced ListTeamCustomXlsformTemplates.php:

    • The statement to use CustomOdkTemplatesWidget was added which is essential for making the above widget work properly.
  • Optimized TeamXlsformTemplateResource.php:

    • Now it uses a config value instead of explicitly stating the owner_type, making the system more adaptive and flexible.
    • Modified it to use the page reference ListTeamXlsformTemplates.
  • Adjusted ListTeamXlsformTemplates.php File Path:

    • Modified the namespace to adjust with the new structure as TeamXlsformTemplateResource.
  • Created New Widget Classes:

    • AvailableOdkTemplatesWidget - This is the widget class that connects with the files previously mentioned to make the effective display of all the existing ODK templates.
    • CustomOdkTemplatesWidget - This widget class works with the files above to display custom templates.
  • Refined Team.php:

    • Made it able to work with different user models, instead of previously only working with the User model.

@dave-mills dave-mills merged commit effec38 into dev Dec 3, 2024
1 check passed
@dave-mills dave-mills deleted the namespace-fixing branch January 22, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants