feat_: Unfurl transaction deep link #5958
Open
+205
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (15)
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## feat/deep-link-16345 #5958 +/- ##
========================================================
- Coverage 47.45% 47.44% -0.01%
========================================================
Files 835 835
Lines 137789 137830 +41
========================================================
+ Hits 65381 65398 +17
- Misses 64633 64658 +25
+ Partials 7775 7774 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3 tasks
igor-sirotin
approved these changes
Oct 17, 2024
| } | ||
| if len(linkTypes) > 1 { | ||
| return fmt.Errorf("multiple components set at the same time: %v", linkTypes) | ||
| } else if len(linkTypes) == 0 { |
There was a problem hiding this comment.
No need for the else
Suggested change
| } else if len(linkTypes) == 0 { | |
| } | |
| if len(linkTypes) == 0 { |
Cuteivist
force-pushed
the
feat/unfurl-deep-link-16345
branch
from
c89bf1c
to
64762e4
Compare
Cuteivist
force-pushed
the
feat/deep-link-16345
branch
from
f234a94
to
4c88939
Compare
Cuteivist
force-pushed
the
feat/unfurl-deep-link-16345
branch
from
64762e4
to
c8698cc
Compare
Cuteivist
changed the title
Cuteivist
force-pushed
the
feat/unfurl-deep-link-16345
branch
from
c8698cc
to
98f79c0
Compare
Cuteivist
force-pushed
the
feat/unfurl-deep-link-16345
branch
from
98f79c0
to
0c7f9f3
Compare
This was referenced Oct 21, 2024
osmaczko
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task status-im/status-desktop#16412
User stories https://www.notion.so/Transaction-deep-link-10d8f96fb65c803c85fed5f4440ad439
Status-desktop change: status-im/status-desktop#16541
NOTE unfurling is based on deep link branch.
This PR must be merged first:
Changes: