Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #2755) Bug fix for psyad failing to transform array assignment #2767

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

arporter
Copy link
Member

@arporter arporter commented Nov 5, 2024

A small change that (pleasingly) only involved me updating some code to remove an old restriction. @DrTVockerodtMO please could you try this branch and let me know whether it solves your problem?

@arporter arporter marked this pull request as draft November 5, 2024 14:18
@arporter arporter added bug Release Planning and creating PSyclone releases adjoint labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (1b55ac0) to head (fb796c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2767   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         354      354           
  Lines       49031    49035    +4     
=======================================
+ Hits        48967    48971    +4     
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arporter arporter marked this pull request as ready for review November 5, 2024 14:50
@arporter
Copy link
Member Author

arporter commented Nov 5, 2024

This needs a 'science' review by @DrTVockerodtMO and then I'll put it up for proper code review.

@DrTVockerodtMO
Copy link
Collaborator

This needs a 'science' review by @DrTVockerodtMO and then I'll put it up for proper code review.

Will be happy to, just need to figure out how to test specific branches on our system and I'll have a look!

@arporter
Copy link
Member Author

arporter commented Nov 8, 2024

@DrTVockerodtMO and I have jointly test this branch against some kernels and everything looks OK. This is therefore ready for review. It's not a big change. Could be one for @hiker, @sergisiso, @LonelyCat124

@arporter
Copy link
Member Author

arporter commented Nov 8, 2024

I've just set the integration tests going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adjoint bug ready for review Release Planning and creating PSyclone releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants