-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #2755) Bug fix for psyad failing to transform array assignment #2767
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2767 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 354 354
Lines 49031 49035 +4
=======================================
+ Hits 48967 48971 +4
Misses 64 64 ☔ View full report in Codecov by Sentry. |
This needs a 'science' review by @DrTVockerodtMO and then I'll put it up for proper code review. |
Will be happy to, just need to figure out how to test specific branches on our system and I'll have a look! |
@DrTVockerodtMO and I have jointly test this branch against some kernels and everything looks OK. This is therefore ready for review. It's not a big change. Could be one for @hiker, @sergisiso, @LonelyCat124 |
I've just set the integration tests going. |
A small change that (pleasingly) only involved me updating some code to remove an old restriction. @DrTVockerodtMO please could you try this branch and let me know whether it solves your problem?