feat(licensing): support custom license templates and decouple terms registration from attachment #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Nov 21, 2024
sebsadface
added a commit
to sebsadface/pp-v1
that referenced
this pull request
Nov 28, 2024
…teWithSig` (storyprotocol#121)" This reverts commit a6fbf2c. Revert "feat(licensing): support custom license templates and decouple terms registration from attachment (storyprotocol#123)" This reverts commit 68f4a4a. Revert "feat(licensing): enable multi-license attachment (storyprotocol#128)" This reverts commit 027eed9.
sebsadface
added a commit
to sebsadface/pp-v1
that referenced
this pull request
Nov 28, 2024
…teWithSig` (storyprotocol#121)" This reverts commit a6fbf2c. Revert "feat(licensing): support custom license templates and decouple terms registration from attachment (storyprotocol#123)" This reverts commit 68f4a4a. Revert "feat(licensing): enable multi-license attachment (storyprotocol#128)" This reverts commit 027eed9.
sebsadface
added a commit
that referenced
this pull request
Nov 29, 2024
…teWithSig` (#121)" (#133) * Revert "refactor(permission): enable direct function calls via `executeWithSig` (#121)" This reverts commit a6fbf2c. Revert "feat(licensing): support custom license templates and decouple terms registration from attachment (#123)" This reverts commit 68f4a4a. Revert "feat(licensing): enable multi-license attachment (#128)" This reverts commit 027eed9. * test(derivative): fix stack too deep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for custom license templates in
LicenseAttachmentWorkflows. It removes the needs for license term IDs prediction during signature generation by decoupling license term registration from theregisterIpAndAttachPILTermsfunction.Key Changes
registerPILTermsAndAttachfunction fromLicenseAttachmentWorkflows.registerIpAndAttachPILTermsis nowregisterIpAndAttachLicenseTerms.mintAndRegisterIpAndAttachLicenseTermsto support IP registration for an existing NFT and attaching pre-registered license terms.Test Plan
Refactored tests to align with the updated functionality. All tests pass locally.
Related Issue
Notes
This PR include API changes, and requires updates to downstream integrations.