Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Social Navigation Layers Support #59

Open
wants to merge 20 commits into
base: hydro-devel
Choose a base branch
from

Conversation

jmcjacob
Copy link

Created the file global_costmap_params_social.yaml that will load the global costmap with the Passing and Proxemic layers. The launch files have also been modified to allow the parameter "with_social_layer" load the new yaml file instead of the original global_costmap_params.yaml when set to true. "with_social_layer" is by default set to false.

@strands-jenkins
Copy link
Contributor

Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request.

@hawesie
Copy link
Member

hawesie commented Aug 10, 2015

ok to test

@marc-hanheide
Copy link
Member

nice one @jmcjacob. @cdondrup did you test this on the robot? Also without the social nav?

@jmcjacob
Copy link
Author

Yes it was all tested on the robot and work fine even without the social navigation layers.

@cdondrup
Copy link
Member

For this to result in human_aware navigation, this needs the social navigation layers turned into a package. @marc-hanheide what do you think is the best way of achieving that? I'd say, forking it to strands and releasing it but I will talk to David first and ask him.

@marc-hanheide
Copy link
Member

Yes, let's fork it and release it! Not even needed to wait for a response, I'd say.

@marc-hanheide
Copy link
Member

sorry, @cdondrup, what's the status with this... do I need to do anything?

@cdondrup
Copy link
Member

cdondrup commented Sep 8, 2015

I will test all this again during this week and let you know. Thanks.

@cdondrup
Copy link
Member

I kind of tested this on Linda but it was a bit hacky due to ICRA deadline and it seems to work nicely. Will do it again properly though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants