Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited movebase.launch to include "with_social_layer" to surport social navigation layers #61

Closed
wants to merge 1 commit into from

Conversation

jmcjacob
Copy link

Added the parameter "with_social_layer" that by default is set to false. The new parameters will allow the use of the Proxemic and Passing layers to be added to the global costmap.

@strands-jenkins
Copy link
Contributor

Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request.

@nilsbore
Copy link
Member

Hi! Is there any reason to add the parameter before the functionality is implemented or could it wait until then?

@marc-hanheide
Copy link
Member

I suppose this is being implemented in another repo? @cdondrup ? Is this in strands-project/scitos_2d_navigation#59 ?

@cdondrup
Copy link
Member

The functionality is implemented by someone else but just not a package yet. I asked to open the PRs because if the parameter is just left to its default value, it will not change the current robot behaviour and won't break anything. Therefore once the repo is turned into a package, this will work as intended.

@nilsbore
Copy link
Member

nilsbore commented Nov 3, 2016

This PR is very outdated, closing.

@nilsbore nilsbore closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants