#882523780845215 Improve autoplay behaviour #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added muted
updated Html elements
fixed options
| // Popcorn.smart( player, src, /* options */ ) | ||
| return Popcorn[ key ]( node, srci, options ); | ||
| // Popcorn.smart( player, src, /* popcornOptions */ ) | ||
| return Popcorn[ key ]( node, srci, popcornOptions, options ); |
There was a problem hiding this comment.
I think it is not necessary
debug muted = true;
removed autoplay
added catch
error => err
true => 'muted'
updated NullElement
removed autoplay
all muted === true
all muted === true
all muted === true
removed mute
updated pause
updated nullVideoElement
added muted = true;
removed muted
updated player
returned changes
returned paused
removed autoplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added muted