Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#882523780845215 Improve autoplay behaviour #37

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
da936f0
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 9, 2019
8101faf
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 14, 2019
cf0ef73
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 14, 2019
a95dadf
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 15, 2019
a276726
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 15, 2019
24e155c
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 15, 2019
7f351bb
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 15, 2019
b42fd7f
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 15, 2019
7c836ee
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 15, 2019
0cfa6d9
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
0fafe7b
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
baf05af
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
fb69e16
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
1e695b9
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
20764ca
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
294d558
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
28518cc
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
7c3f280
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
fe73a2e
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
315b57d
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
77213d1
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
3a5f933
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
c04b047
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
d035142
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 17, 2019
c272621
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 21, 2019
4c65edd
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 21, 2019
a83cd68
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 21, 2019
82cf6b1
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 21, 2019
bf57fc3
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 21, 2019
7c9d4a0
#882523780845215 Improve autoplay behaviour
EkaterinaMaksimlyuk Jan 21, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#882523780845215 Improve autoplay behaviour
added catch
EkaterinaMaksimlyuk committed Jan 17, 2019
commit 0fafe7b249e6ce128da1ade7f3a255fdbf232449
4 changes: 3 additions & 1 deletion wrappers/html5/popcorn.HTMLMediaElement.js
Original file line number Diff line number Diff line change
@@ -89,7 +89,9 @@
media._play = media.play;
media._pause = media.pause;
media.play = function () {
media._play();
media._play().catch(err => {
console.error(error.message);
});
};
media.pause = function () {
media._pause();