Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add subscription expiration option to namespaces #133

Merged
merged 8 commits into from
Mar 4, 2025
Merged

[feat] Add subscription expiration option to namespaces #133

merged 8 commits into from
Mar 4, 2025

Conversation

klevy-toast
Copy link
Contributor

@klevy-toast klevy-toast commented Dec 31, 2024 •
edited
Loading

Fixes #132

Adds a new setting to namespace config for subscription expiration time

Modifications

Adds support for the subscription expiration time.

Also bumps the pulsar-client-go library to 0.14, and reorder arguments alphabetically within the namespace_config object.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as namespace tests

Documentation

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@klevy-toast klevy-toast requested a review from a team as a code owner December 31, 2024 00:38
@github-actions github-actions bot added the doc This pr contains a document label Dec 31, 2024
@klevy-toast
Copy link
Contributor Author

@freeznet @maxsxu this is ready for review, thanks

lhotari
lhotari approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @klevy-toast

@lhotari
Copy link
Member

lhotari commented Feb 20, 2025

@tuteng @ericsyh Please review

@tuteng tuteng merged commit ad23644 into streamnative:master Mar 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

@tuteng tuteng tuteng approved these changes

Assignees

@klevy-toast klevy-toast

Labels
doc This pr contains a document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add subscription expiration time to namespace config
3 participants
@klevy-toast @lhotari @tuteng