Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to preprocess non-GH evolution data #6502

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Feb 27, 2025

Proposed changes

This allows codes that evolve BSSN or a variant of Z4 to dump the extrinsic curvature and auxiliary shift vector rather than the time derivative of the metric, lapse, and shift. We then compute these time derivatives instead, assuming 1+log slicing and the gamma-driver condition for the shift. If different lapse and shift conditions will be useful to the community, they can be added later but this should cover a large number of codes already.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsdeppe February 27, 2025 00:08
@knelli2 knelli2 force-pushed the preprocess_cce_ext_curve branch 3 times, most recently from 6cb3d24 to 4589412 Compare February 27, 2025 18:17
knelli2 added 2 commits March 7, 2025 11:42
Adds ability to compute time derivs from 1+log slicing and gamma
driver shift condition for either BSSN of Z4c formulations.
@knelli2 knelli2 force-pushed the preprocess_cce_ext_curve branch from 4589412 to 927a2fb Compare March 7, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant