Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve non-deterministic tests #329

Open
marcelomorgado opened this issue Apr 18, 2019 · 9 comments
Open

Solve non-deterministic tests #329

marcelomorgado opened this issue Apr 18, 2019 · 9 comments
Labels
important and urgent tech debt Technical debt not involving bugs or features
Milestone

Comments

@marcelomorgado
Copy link
Contributor

Deal with already skipped test cases plus:

TasitAction.Contract > should emit error event when block reorganization occurs - tx confirmed twice (refs)

@marcelomorgado marcelomorgado added the tech debt Technical debt not involving bugs or features label Apr 18, 2019
@marcelomorgado marcelomorgado added this to the 0.2.0 release milestone Apr 18, 2019
@marcelomorgado
Copy link
Contributor Author

marcelomorgado commented Apr 29, 2019

Some test cases still disabled (skipped) and some confirmations/blocks counts still as non-deterministic.
I think that all cases could be solved when these issues were addressed:

@pcowgill
Copy link
Member

@marcelomorgado Makes sense. Thanks for the update!

@marcelomorgado
Copy link
Contributor Author

Recent failures to be addressed:

TasitAction.Contract > Transactions (Actions) Subscription > should be able to listen to an event before sending
Move from to.equal to to.be.at.least

TasitAction.Contract > Transactions (Actions) Subscription > should emit error event when block reorganization occurs - tx confirmed twice
Skip for now since no call was made to the listener.

@marcelomorgado
Copy link
Contributor Author

Since PR #386 we haven't non-deterministic test cases anymore.
We can close this or wait for more test rounds before make sure that issues were solved.

@pcowgill
Copy link
Member

pcowgill commented May 7, 2019

Okay, great!! Thanks. I'll set a reminder to close this in two days if we don't run into any intermittent issues.

@pcowgill
Copy link
Member

pcowgill commented May 8, 2019

The test suite passed in this PR #389 , so that's good

@pcowgill
Copy link
Member

pcowgill commented May 8, 2019

@marcelomorgado This merge into develop didn't have the tests pass:

https://circleci.com/gh/tasitlabs/TasitSDK/655

tasit-action:   1) TasitAction.Contract
tasit-action:        Contract Events Subscription
tasit-action:          contract should call error listener after timeout:
tasit-action:      Error: Timeout of 8000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/circleci/tasit-sdk/packages/tasit-action/src/contract/Contract.test.js)

@marcelomorgado
Copy link
Contributor Author

I'll skip this test again for now.

@pcowgill
Copy link
Member

pcowgill commented May 8, 2019

I'll skip this test again for now.

Okay, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important and urgent tech debt Technical debt not involving bugs or features
Projects
None yet
Development

No branches or pull requests

2 participants