Event timeouts #386
Merged
Event timeouts #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the description of the PR to remove the part about closing the non-deterministic tests issue automatically based on my comment over in that issue |
pcowgill
approved these changes
May 7, 2019
| return this.#timeout; | ||
| }; | ||
|
|
||
| setEventsTimeout = timeout => { |
There was a problem hiding this comment.
Should we call it something other than events to indicate that it can relate to confirmations too and not just “contract events”?
There was a problem hiding this comment.
Ok, setTimeout sounds good?
This was referenced May 8, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#384
#329
#379 (comment)
#379 (comment)
Auto-close the issue?
Closes #384
Types of changes
Bug fix (non-breaking change that fixes an issue)
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)