-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event timeouts #386
Event timeouts #386
Conversation
I updated the description of the PR to remove the part about closing the non-deterministic tests issue automatically based on my comment over in that issue |
return this.#timeout; | ||
}; | ||
|
||
setEventsTimeout = timeout => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call it something other than events to indicate that it can relate to confirmations too and not just “contract events”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, setTimeout
sounds good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah!
Issue link
#384
#329
#379 (comment)
#379 (comment)
Auto-close the issue?
Closes #384
Types of changes
Bug fix (non-breaking change that fixes an issue)
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)