Add a pre-commit setup to the repository. #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
4 tasks
chmouel
reviewed
Nov 14, 2023
vdemeester
force-pushed
the
add-pre-commit
branch
from
24204c0
to
2c041b9
Compare
chmouel
reviewed
Nov 14, 2023
vdemeester
force-pushed
the
add-pre-commit
branch
from
2c041b9
to
6a8e0db
Compare
|
I am good with the pre-commit part but still have concerns about .env file committed into the repo, the linked wiki page in the direnv wiki is not very clear of the advantages of doing this.... |
This will allow us to run some checks before committing. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
add-pre-commit
branch
from
6a8e0db
to
22d86d8
Compare
|
Thanks for the update without dotenv, /lgtm |
|
I guess the note about pre-commit installation should be in the https://github.com/tektoncd/cli/blob/main/DEVELOPMENT.md#requirements 🤔 |
|
@roman-kiselenko that would be a great in this document have a brief explanation about what pre-commit does and how to install the hooks (basically run pre-commit binary at the root directory) maybe mentions this as well in the pull request template with a link to that doc |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vinamra28
added a commit
that referenced
this pull request
Jan 11, 2024
#2178 | [vinamra28] Bump choco and readme to v0.33.0 | 2023/11/16-07:52 #2178 | [vinamra28] Fix the release script | 2023/11/16-07:52 #2177 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.53.0 to 0.53.1 | 2023/11/16-11:30 #2180 | [dependabot[bot]] Bump github.com/tektoncd/triggers from 0.25.2 to 0.25.3 | 2023/11/16-18:28 #2181 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.53.1 to 0.53.2 | 2023/11/17-07:00 #2179 | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.26.10 to 0.26.11 | 2023/11/17-07:40 #2182 | [dependabot[bot]] Bump github.com/creack/pty from 1.1.20 to 1.1.21 | 2023/11/20-06:08 #2130 | [William Fish] update the `task start` cmd to also allow an oci bundle with a task name to be created from the cli | 2023/11/21-10:00 #2130 | [William Fish] update make lint to run goimports and download it to the correct place | 2023/11/21-10:00 #2176 | [Vincent Demeester] Add a pre-commit setup to the repository. | 2023/11/21-15:38 null | [dependabot[bot]] Bump github.com/go-jose/go-jose/v3 from 3.0.0 to 3.0.1 | 2023/11/22-06:36 null | [dependabot[bot]] Bump github.com/tektoncd/hub from 1.15.0 to 1.15.1 | 2023/11/27-15:20 null | [dependabot[bot]] Bump knative.dev/serving | 2023/11/28-11:02 null | [dependabot[bot]] Bump golang.org/x/term from 0.14.0 to 0.15.0 | 2023/11/29-04:10 null | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.53.2 to 0.54.0 | 2023/11/29-05:06 null | [dependabot[bot]] Bump github.com/ktr0731/go-fuzzyfinder from 0.7.0 to 0.8.0 | 2023/11/30-16:06 null | [dependabot[bot]] Bump github.com/theupdateframework/go-tuf from 0.6.1 to 0.7.0 | 2023/12/01-06:56 null | [dependabot[bot]] Bump github.com/google/go-containerregistry from 0.16.1 to 0.17.0 | 2023/12/02-05:48 null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.7.5 to 1.7.6 | 2023/12/05-04:02 null | [dependabot[bot]] Bump golang.org/x/crypto from 0.16.0 to 0.17.0 | 2023/12/19-07:22 null | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.54.0 to 0.54.1 | 2023/12/21-07:16 null | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.54.1 to 0.54.2 | 2023/12/22-02:10 null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.7.6 to 1.8.0 | 2023/12/22-03:22 null | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.26.11 to 0.26.12 | 2023/12/22-04:20 null | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.54.2 to 0.55.0 | 2023/12/22-06:58 null | [Piyush Garg] Bump sigstore/cosign to v2.2.2 | 2023/12/22-13:42 null | [PuneetPunamiya] Adds hub version in output of `tkn version` command | 2024/01/03-07:22 null | [dependabot[bot]] Bump golang.org/x/term from 0.15.0 to 0.16.0 | 2024/01/07-07:54 null | [dependabot[bot]] Bump github.com/cloudflare/circl from 1.3.5 to 1.3.7 | 2024/01/09-06:54 null | [vinamra28] Bump golang and goreleaser versions | 2024/01/11-11:12 Signed-off-by: vinamra28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will allow us to run some checks before committing. If
direnvis enabled in the developer environment andpre-commitavailable, it will automatically install the hooks for the repository.On top of #2175.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes