Bump go.mod and tools/go.mod to go 1.23 #8482
Conversation
tekton-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
size/XS
vdemeester
force-pushed
the
bump-to-go-1.23
branch
from
efcef55 to
6d551d1
Compare
tekton-robot
removed
the
needs-rebase
Some dependencies depends on will depend on 1.23, and the test-runner image already is up-to-date, so let's use it. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
bump-to-go-1.23
branch
from
6d551d1 to
aa144d5
Compare
tekton-robot
added
size/S
| @@ -44,15 +44,15 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Check out code onto GOPATH | |||
| uses: actions/checkout@v4 | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
| with: | |||
| path: ${{ github.workspace }}/src/github.com/tektoncd/pipeline | |||
There was a problem hiding this comment.
@afrittoli any reason to checkout into GOPATH ? It shouldn't be needed nowadays (GOPATH I mean)
There was a problem hiding this comment.
ko does not work otherwise, last I tried. It may be different now.
There was a problem hiding this comment.
@afrittoli you mean ko on the github worklows ? Because it definitely works locally for me.
There was a problem hiding this comment.
Yes, but I didn't really try too hard to make it work, it just worked when checking out that way, so I kept it.
If you'd like to change it, it's perfectly fine by me, I don't have a preference 🙏
|
/test pull-tekton-pipeline-build-tests |
|
@vdemeester: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@vdemeester the build tests are failing |
Changes
Some dependencies will depend on 1.23, and the test-runner
image already is up-to-date, so let's use it.
Signed-off-by: Vincent Demeester [email protected]
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes