Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.mod and tools/go.mod to go 1.23 #8482

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump go.mod and tools/go.mod to go 1.23 #8482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a34eb86
Bump go.mod and tools/go.mod to go 1.23
vdemeester Jan 13, 2025
aa144d5
.github/workflows: update setup-go to use go.mod version
vdemeester Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Setup go
uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5
with:
go-version: '1.22.x'
go-version-file: go.mod

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e-matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ jobs:

steps:
- name: Check out code onto GOPATH
uses: actions/checkout@v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
path: ${{ github.workspace }}/src/github.com/tektoncd/pipeline
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrittoli any reason to checkout into GOPATH ? It shouldn't be needed nowadays (GOPATH I mean)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ko does not work otherwise, last I tried. It may be different now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrittoli you mean ko on the github worklows ? Because it definitely works locally for me.

Copy link
Member

@afrittoli afrittoli Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I didn't really try too hard to make it work, it just worked when checking out that way, so I kept it.
If you'd like to change it, it's perfectly fine by me, I don't have a preference 🙏



- name: Set up Go 1.22
uses: actions/setup-go@v5
- name: Set up Go (from go.mod)
uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5
with:
go-version: 1.22.5
go-version-file: ${{ github.workspace }}/src/github.com/tektoncd/pipeline/go.mod

- name: Install Dependencies
working-directory: ./
Expand Down
4 changes: 1 addition & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module github.com/tektoncd/pipeline

go 1.22.3

toolchain go1.22.7
go 1.23

require (
github.com/Microsoft/go-winio v0.6.2 // indirect
Expand Down
4 changes: 1 addition & 3 deletions tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module github.com/tektoncd/pipeline/tools

go 1.22.1

toolchain go1.22.5
go 1.23

require github.com/golangci/golangci-lint v1.63.4

Expand Down
Loading