#0: Provide an example of hybrid TP/DP using all-gather with line topology #17882
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfjchu
requested review from
ayerofieiev-tt,
dmakoviichuk-tt and
omilyutin-tt
as code owners
cfjchu
changed the title
cfjchu
force-pushed
the
jchu/tp-dp-example-for-distributed-training
branch
from
47c8723 to
7955e16
Compare
cfjchu
force-pushed
the
jchu/tp-dp-example-for-distributed-training
branch
from
7955e16 to
c3ed58e
Compare
| # [A0, A0, A0, A0] | ||
| # [A1, A1, A1, A1] | ||
| hidden_states, parameters = None, None | ||
| mesh_shape = tuple(mesh_device.shape) |
There was a problem hiding this comment.
Yikes that we need to do this. I'll fix.
omilyutin-tt
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
There aren't any good examples of hybrid tensor and data-parallel implemented via line all-gather. Providing this as a reference for the training team.
What's changed
Added an example for this. Follows similar format to
tests/ttnn/distributed/test_data_parallel_example.pyandtests/ttnn/distributed/test_tensor_parallel_example.pyChecklist