Added a simple token migration for dashes #390
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically migrates simple tokens using
-
to using_
. The alternative would be to allow both,-
as well as_
but I'm still not sure this is a good idea from a UX perspective...Background: Contao's SimpleTokenParser (or Symfony Expression Language) cannot handle tokens with
-
. Thus, you cannot use them in{if
conditions. Hence, there are 2 solutions:-
to_
and migrate existing data (current solution with this PR)##e-mail##
so that you can write{if e_mail ...}##e-mail##{endif}
So 1. would have consistent tokens everywhere but force users to re-think somehow. With the migration in this PR it would be complete, though. 2. would have inconsistent tokens but maybe this is better?