Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs require Ruby version that's EOL since 2014 #59

Open
walles opened this issue Sep 27, 2021 · 0 comments
Open

Specs require Ruby version that's EOL since 2014 #59

walles opened this issue Sep 27, 2021 · 0 comments

Comments

@walles
Copy link

walles commented Sep 27, 2021

README.md says:

The specs must be run with Ruby 1.8.7 (p358).

However, Ruby 1.8.7 went End of Life in 2014: https://www.ruby-lang.org/en/news/2014/07/01/eol-for-1-8-7-and-1-9-2/

I just tried to use RVM to install Ruby 1.8.7 on my mac, but the installation failed because of compilation errors.

What I really want to do is to fix the Git Commit Message grammar to work on non-English locales. And for that I want to run the specs so I don't break anything, and to make sure my changes do what I expect.

What would be the easiest way for me to run the specs?

walles added a commit to walles/vscode that referenced this issue Sep 27, 2021
This grammar has not been updated since 2016:
https://github.com/textmate/git.tmbundle/blob/master/Syntaxes/Git%20Commit%20Message.tmLanguage

The upstream test suite requires running a Ruby version that has been
EOL since 2014, and that I failed to build on macOS:
textmate/git.tmbundle#59

If this change is accepted, my plan is to add support to vscode for
highlighting non-English commit messages:
textmate/git.tmbundle#60

And even if I never get around to that, this at least opens up the
possibility for somebody else to do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant